linux-kernel - Re: [PATCH 2/9] spi: atmel: Use dma_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90cd6e97-2eda-934a-3175-b7d93d86115a@microchip.com>
Date:   Wed, 13 Nov 2019 14:18:37 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <peter.ujfalusi@...com>, <broonie@...nel.org>,
        <radu_nicolae.pirea@....ro>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <linus.walleij@...aro.org>,
        <agross@...nel.org>, <bjorn.andersson@...aro.org>,
        <andi@...zian.org>, <ldewangan@...dia.com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>
CC:     <alexandre.belloni@...tlin.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <krzk@...nel.org>,
        <linux-spi@...r.kernel.org>, <vkoul@...nel.org>,
        <kgene@...nel.org>, <linux-tegra@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for
 channel request

On 13/11/2019 at 10:42, Peter Ujfalusi wrote:
> 
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

I'm not sure we need one patch per driver. If series taken:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/spi/spi-atmel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 9e84a93083bc..56f0ca361deb 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -511,7 +511,7 @@ static int atmel_spi_configure_dma(struct spi_master *master,
>   	dma_cap_zero(mask);
>   	dma_cap_set(DMA_SLAVE, mask);
>   
> -	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
> +	master->dma_tx = dma_request_chan(dev, "tx");
>   	if (IS_ERR(master->dma_tx)) {
>   		err = PTR_ERR(master->dma_tx);
>   		if (err == -EPROBE_DEFER) {
> 


-- 
Nicolas Ferre