linux-kernel - Re: [PATCH 1/9] spi: at91-usart: Use dma_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05f47be4-f58a-d61f-92e1-c4985c4c3680@microchip.com>
Date:   Wed, 13 Nov 2019 14:18:51 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <peter.ujfalusi@...com>, <broonie@...nel.org>,
        <radu_nicolae.pirea@....ro>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <linus.walleij@...aro.org>,
        <agross@...nel.org>, <bjorn.andersson@...aro.org>,
        <andi@...zian.org>, <ldewangan@...dia.com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>
CC:     <alexandre.belloni@...tlin.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <krzk@...nel.org>,
        <linux-spi@...r.kernel.org>, <vkoul@...nel.org>,
        <kgene@...nel.org>, <linux-tegra@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/9] spi: at91-usart: Use dma_request_chan() directly for
 channel request

On 13/11/2019 at 10:42, Peter Ujfalusi wrote:
> External E-Mail
> 
> 
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/spi/spi-at91-usart.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
> index a40bb2ef89dc..88033422a42a 100644
> --- a/drivers/spi/spi-at91-usart.c
> +++ b/drivers/spi/spi-at91-usart.c
> @@ -132,7 +132,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
>   	dma_cap_zero(mask);
>   	dma_cap_set(DMA_SLAVE, mask);
>   
> -	ctlr->dma_tx = dma_request_slave_channel_reason(dev, "tx");
> +	ctlr->dma_tx = dma_request_chan(dev, "tx");
>   	if (IS_ERR_OR_NULL(ctlr->dma_tx)) {
>   		if (IS_ERR(ctlr->dma_tx)) {
>   			err = PTR_ERR(ctlr->dma_tx);
> @@ -145,7 +145,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
>   		goto at91_usart_spi_error_clear;
>   	}
>   
> -	ctlr->dma_rx = dma_request_slave_channel_reason(dev, "rx");
> +	ctlr->dma_rx = dma_request_chan(dev, "rx");
>   	if (IS_ERR_OR_NULL(ctlr->dma_rx)) {
>   		if (IS_ERR(ctlr->dma_rx)) {
>   			err = PTR_ERR(ctlr->dma_rx);
> 


-- 
Nicolas Ferre