[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdYhy1KLyZd4MNSODpy0Q59_SAcc+wkofrZr4b4N+rYDxw@mail.gmail.com>
Date: Wed, 13 Nov 2019 15:46:47 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>,
Andriy Shevchenko <andriy.shevchenko@...el.com>,
qi-ming.wu@...el.com, yixin.zhu@...ux.intel.com,
cheol.yong.kim@...el.com
Subject: Re: [PATCH v6 2/2] dt-bindings: pinctrl: intel: Add for new SoC
On Mon, Nov 11, 2019 at 11:11 AM Rahul Tanwar
<rahul.tanwar@...ux.intel.com> wrote:
> Add dt bindings document for pinmux & GPIO controller driver of
> Intel Lightning Mountain SoC.
>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
(...)
> +properties:
> + compatible:
> + const: intel,lgm-pinctrl
Just noted from another review where Rob noted that this name should
match the internal name in the datasheet for this hardware block. Is it
really called "lgm-pinctrl" inside Intel?
intel,lightning-mountain-io and similar are perfectly fine if that is the
name it has in your documentation.
Yours,
Linus Walleij
Powered by blists - more mailing lists