linux-kernel - Re: [PATCH] staging: exfat: Fix CamelCase in function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191113214655.GB3926041@kroah.com>
Date:   Thu, 14 Nov 2019 05:46:55 +0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Javier F. Arias" <jarias.linux@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: exfat: Fix CamelCase in function names

On Wed, Nov 13, 2019 at 12:43:48PM -0500, Javier F. Arias wrote:
> This patch fixes CamelCase in function names with the ffs prefix.
> Issue found by checkpatch.
> 
> Signed-off-by: Javier F. Arias <jarias.linux@...il.com>
> ---
>  drivers/staging/exfat/exfat_super.c | 84 ++++++++++++++---------------
>  1 file changed, 42 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 23002aefc964..a6bbf0d7d378 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)
>  		EXFAT_I(inode)->fid.attr = attr & (ATTR_RWMASK | ATTR_READONLY);
>  }
>  
> -static int ffsMountVol(struct super_block *sb)
> +static int ffs_mount_vol(struct super_block *sb)

Can't you just get rid of the crazy ffs prefix as well?

That would be best, look at the TODO file, it says to do just that :)

thanks,

greg k-h