linux-kernel - Re: [PATCH] firmware_class: make firmware caching configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Nov 2019 05:50:31 +0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mark Salyzyn <salyzyn@...roid.com>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Tim Murray <timmurray@...gle.com>,
        Venkata Narendra Kumar Gutta <vnkgutta@...eaurora.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH] firmware_class: make firmware caching configurable

On Wed, Nov 13, 2019 at 01:01:13PM -0800, Mark Salyzyn wrote:
> Because firmware caching generates uevent messages that are sent over
> a netlink socket, it can prevent suspend on many platforms.  It's
> also not always useful, so make it a configurable option.
> 
> Signed-off-by: Mark Salyzyn <salyzyn@...roid.com>
> Cc: Tim Murray <timmurray@...gle.com>
> Cc: Venkata Narendra Kumar Gutta <vnkgutta@...eaurora.org>
> Acked-by: Luis Chamberlain <mcgrof@...nel.org>
> ---
>  drivers/base/Kconfig                | 13 +++++++++++++
>  drivers/base/firmware_loader/main.c |  6 +++---
>  2 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 28b92e3cc570..36351c3a62b0 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -89,6 +89,19 @@ config PREVENT_FIRMWARE_BUILD
>  
>  source "drivers/base/firmware_loader/Kconfig"
>  
> +config FW_CACHE
> +	bool "Enable firmware caching during suspend"
> +	depends on PM_SLEEP
> +	default y
> +	help
> +	  Because firmware caching generates uevent messages that are sent
> +	  over a netlink socket, it can prevent suspend on many platforms.
> +	  It is also not always useful, so on such platforms we have the
> +	  option.
> +
> +	  If unsure, say Y.
> +
> +

Shouldn't this entry go into drivers/base/firmware_loader/Kconfig
instead and depend on FW_LOADER by putting it in the correct location in
that file?

Also, no need for two blank lines.

And finally, 'default y' is only a good idea if your machine can not
boot without the option.  I don't think that's the case here, correct?

thanks,

greg k-h