linux-kernel - Re: [PATCH] firmware_class: make firmware caching configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113221318.GA11244@42.do-not-panic.com>
Date:   Wed, 13 Nov 2019 22:13:18 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Mark Salyzyn <salyzyn@...roid.com>, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com, Tim Murray <timmurray@...gle.com>,
        Venkata Narendra Kumar Gutta <vnkgutta@...eaurora.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] firmware_class: make firmware caching configurable

On Thu, Nov 14, 2019 at 05:50:31AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 13, 2019 at 01:01:13PM -0800, Mark Salyzyn wrote:
> > +config FW_CACHE
> > +	bool "Enable firmware caching during suspend"
> > +	depends on PM_SLEEP
> > +	default y
> And finally, 'default y' is only a good idea if your machine can not
> boot without the option.  I don't think that's the case here, correct?

default y if PM_SLEEP

Would try to enable this if PM_SLEEP was disabled. So the depends on
will force this on for all systems by default if PM_SLEEP is enabled,
which is what how this works today.

We enable this feature today by default if you have PM_SLEEP.

  Luis