linux-kernel - Re: [PATCH] Input: cyttsp4_core: fix use after free bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191113010443.GM13374@dtor-ws>
Date:   Tue, 12 Nov 2019 17:04:43 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Pan Bian <bianpan2016@....com>
Cc:     Ferruh Yigit <fery@...ress.com>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: cyttsp4_core: fix use after free bug

On Tue, Nov 05, 2019 at 02:46:19PM +0800, Pan Bian wrote:
> The device md->input is used after it is released. Setting the device
> data to NULL is unnecessary as the device is never used again. Instead,
> md->input should be assigned NULL to avoid accessing the freed memory
> accidently.

No, we are tearing up the device anyway, I'd leave it as it was, so I'll
drop this chunk and apply the rest.

Thank you.

-- 
Dmitry