linux-kernel - Re: [PATCH 31/33] powerpc/64: make buildable without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0ikEMP6MQzL8QPMTgdA-euf7_AsFZAbxkDbFh=smMuaQ@mail.gmail.com>
Date:   Wed, 13 Nov 2019 11:04:03 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Michal Suchánek <msuchanek@...e.de>
Cc:     Nicholas Piggin <npiggin@...il.com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Allison Randal <allison@...utok.net>,
        Andrew Donnellan <andrew.donnellan@....ibm.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Brajeswar Ghosh <brajeswar.linux@...il.com>,
        Claudio Carvalho <cclaudio@...ux.ibm.com>,
        Christian Brauner <christian@...uner.io>,
        Christophe Leroy <christophe.leroy@....fr>,
        David Hildenbrand <david@...hat.com>,
        David Howells <dhowells@...hat.com>,
        Diana Craciun <diana.craciun@....com>,
        Daniel Axtens <dja@...ens.net>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Firoz Khan <firoz.khan@...aro.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Gustavo Romero <gromero@...ux.ibm.com>,
        Hari Bathini <hbathini@...ux.ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Jagadeesh Pagadala <jagdsh.linux@...il.com>,
        Breno Leitao <leitao@...ian.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>,
        Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
        Mathieu Malaterre <malat@...ian.org>,
        Michael Neuling <mikey@...ling.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        Nicolai Stange <nstange@...e.de>,
        Oleg Nesterov <oleg@...hat.com>,
        Paul Mackerras <paulus@...ba.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Russell Currey <ruscur@...sell.cc>,
        Thomas Gleixner <tglx@...utronix.de>,
        Valentin Schneider <valentin.schneider@....com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH 31/33] powerpc/64: make buildable without CONFIG_COMPAT

On Wed, Nov 13, 2019 at 9:41 AM Michal Suchánek <msuchanek@...e.de> wrote:
>
> On Wed, Nov 13, 2019 at 01:02:34PM +1000, Nicholas Piggin wrote:

> > >
> > > @@ -277,7 +276,7 @@ static void do_signal(struct task_struct *tsk)
> > >
> > >     rseq_signal_deliver(&ksig, tsk->thread.regs);
> > >
> > > -   if (is32) {
> > > +   if (is_32bit_task()) {
> > >             if (ksig.ka.sa.sa_flags & SA_SIGINFO)
> > >                     ret = handle_rt_signal32(&ksig, oldset, tsk);
> > >             else
> >
> > This is just a clean up I guess.
>
> It also expands directly to if(0) or if(1) for the !COMPAT cases. I am
> not sure how it would work with the intermediate variable.
>
> There was more complex change initially but after some additional
> cleanups removing the variable is the only part left.

I would be surprised if that made any difference to a modern compiler,
but the new version is definitely clearer to human readers.

       Arnd