[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191114164426.GC9528@linux.intel.com>
Date: Thu, 14 Nov 2019 18:44:26 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc: linux-integrity@...r.kernel.org, jsnitsel@...hat.com,
linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org,
Stefan Berger <stefanb@...ux.ibm.com>
Subject: Re: [PATCH] tpm_tis: Move setting of TPM_CHIP_FLAG_IRQ into
tpm_tis_probe_irq_single
On Thu, Nov 14, 2019 at 06:41:51PM +0200, Jarkko Sakkinen wrote:
> On Tue, Nov 12, 2019 at 03:27:25PM -0500, Stefan Berger wrote:
> > From: Stefan Berger <stefanb@...ux.ibm.com>
> >
> > Move the setting of the TPM_CHIP_FLAG_IRQ for irq probing into
> > tpm_tis_probe_irq_single before calling tpm_tis_gen_interrupt.
> > This move handles error conditions better that may arise if anything
> > before fails in tpm_tis_probe_irq_single.
> >
> > Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> > Suggested-by: Jerry Snitselaar <jsnitsel@...hat.com>
>
> What about just changing the condition?
Also cannot take this since it is not a bug (no fixes tag).
/Jarkko
Powered by blists - more mailing lists