linux-kernel - Re: [PATCH net-next] cnic: Fix Kconfig warning without MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191115.121415.1822375480431062908.davem@davemloft.net>
Date:   Fri, 15 Nov 2019 12:14:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     f.fainelli@...il.com, jiri@...lanox.com, geert+renesas@...der.be,
        jakub.kicinski@...ronome.com, gospo@...adcom.com,
        rdunlap@...radead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] cnic: Fix Kconfig warning without MMU

From: YueHaibing <yuehaibing@...wei.com>
Date: Thu, 14 Nov 2019 17:02:19 +0800

> If MMU is not set, Kconfig warning this:
> 
> WARNING: unmet direct dependencies detected for UIO
>   Depends on [n]: MMU [=n]
>   Selected by [y]:
>   - CNIC [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=y] || IPV6 [=y]=n)
> 
> Make CNIC depend on UIO instead of select it to fix this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

This makes no sense, if you need MMU then guard on MMU.

UIO is for userspace device drivers, and not something that CNIC
requires.