linux-kernel - Re: 8250-men-mcb: fix signed/unsigned confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191116133748.GB454551@kroah.com>
Date:   Sat, 16 Nov 2019 14:37:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     kernel list <linux-kernel@...r.kernel.org>,
        colin.king@...onical.com, mmoese@...e.de, sashal@...nel.org
Subject: Re: 8250-men-mcb: fix signed/unsigned confusion

On Fri, Nov 15, 2019 at 10:13:51PM +0100, Pavel Machek wrote:
> On Fri 2019-11-15 23:09:42, Greg KH wrote:
> > On Fri, Nov 15, 2019 at 01:52:34PM +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > Commit 5210a3a722543fc25b8830d2236dcbe2c8178468 fixes part of
> > > signed/unsigned confusion, but not all of it.
> > > 
> > > 8250-men-mcb: fix error checking when get_num_ports returns -ENODEV
> > > Upstream commit f50b6805dbb993152025ec04dea094c40cc93a0c
> > > 
> > > Fix function returning -ENODEV to signed prototype, and make error
> > > check consistent between two functions.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@...x.de>
> > > 
> > 
> > Hi,
> > 
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually
> > respond
> 
> Not sure what is supposed to be friendly about this bot.

How was it not?  Did it not say exactly what was wrong with the patch
and how to change it to make it acceptable?

> Anyway, it would be nice if authors of
> 5210a3a722543fc25b8830d2236dcbe2c8178468 picked this up. I have no way
> to test it.

As the bot said, this patch is not acceptable as-is, sorry.  There's no
way it can be 'picked up' in this format.

thanks,

greg k-h