linux-kernel - Re: [PATCH 1/3] firmware: google: Release devices before unregistering the bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191116133849.GC454551@kroah.com>
Date:   Sat, 16 Nov 2019 14:38:49 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     patrick.rudolph@...ements.com
Cc:     linux-kernel@...r.kernel.org, coreboot@...eboot.org,
        Allison Randal <allison@...utok.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Arthur Heymans <arthur@...ymans.xyz>
Subject: Re: [PATCH 1/3] firmware: google: Release devices before
 unregistering the bus

On Fri, Nov 15, 2019 at 02:48:37PM +0100, patrick.rudolph@...ements.com wrote:
> From: Patrick Rudolph <patrick.rudolph@...ements.com>
> 
> Fix a bug where the kernel module can't be loaded after it has been
> unloaded as the devices are still present and conflicting with the
> to be created coreboot devices.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> ---
>  drivers/firmware/google/coreboot_table.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c
> index 8d132e4f008a..88c6545bebf4 100644
> --- a/drivers/firmware/google/coreboot_table.c
> +++ b/drivers/firmware/google/coreboot_table.c
> @@ -163,8 +163,14 @@ static int coreboot_table_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> +static int __cb_dev_unregister(struct device *dev, void *dummy)
> +{
> +	device_unregister(dev);

Did you build this patch???

Did it work when you tested it?  How?

Please fix up,

greg k-h