linux-kernel - Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic BIOS fan control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191116155945.tivygva3rbbdolgz@pali>
Date:   Sat, 16 Nov 2019 16:59:45 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Giovanni Mascellani <gio@...ian.org>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic
 BIOS fan control

On Saturday 16 November 2019 07:53:10 Guenter Roeck wrote:
> On 11/16/19 6:58 AM, Pali Rohár wrote:
> > On Saturday 16 November 2019 15:06:49 Giovanni Mascellani wrote:
> > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > index 4212d022d253..67b8c0adede8 100644
> > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > @@ -68,6 +68,8 @@ static uint i8k_pwm_mult;
> > >   static uint i8k_fan_max = I8K_FAN_HIGH;
> > >   static bool disallow_fan_type_call;
> > >   static bool disallow_fan_support;
> > > +static unsigned int smm_manual_fan;
> > > +static unsigned int smm_auto_fan;
> 
> The "smm_" prefix does not have any value here.

These variables store SMM command numbers and seems that in this patch
they were converted from macros "#define I8K_SMM_MANUAL_FAN	0x34a3"

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)