linux-kernel - Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic BIOS fan control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e938f226-f9f1-0c17-865c-45942e9287e8@debian.org>
Date:   Sat, 16 Nov 2019 18:12:23 +0100
From:   Giovanni Mascellani <gio@...ian.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Pali Rohár <pali.rohar@...il.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic
 BIOS fan control

Hi,

Il 16/11/19 16:53, Guenter Roeck ha scritto:
>>>   @@ -1135,12 +1183,48 @@ static struct dmi_system_id
>>> i8k_blacklist_fan_support_dmi_table[] __initdata = {
>>>       { }
>>>   };
>>>   +struct i8k_manual_fan_data {
>>> +    unsigned int smm_manual_fan;
>>> +    unsigned int smm_auto_fan;
>>> +};
>>
>> Just cosmetic suggestion: As this structure contains data for both
>> manual and automatic mode I would not use "manual" in name. But e.g.
>> something like "i8k_bios_fan_control_data"...
>>
> Or i8k_fan_control_data. Also, "manual" and "auto" for the variable
> names would be sufficient.

"auto" is a keyword, so I cannot use it. I've left "manual_fan" and
"auto_fan" therefore.

Thanks and ack for all the other changes. I'll submit the updated patch
shortly.

Giovanni.
-- 
Giovanni Mascellani <g.mascellani@...il.com>
Postdoc researcher - Université Libre de Bruxelles



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)