linux-kernel - Re: [PATCH] perf/x86/uncore: Remove unnecessary check for uncore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191118143636.GD22736@duo.ucw.cz>
Date:   Mon, 18 Nov 2019 15:36:36 +0100
From:   Pavel Machek <pavel@...x.de>
To:     kan.liang@...ux.intel.com
Cc:     peterz@...radead.org, mingo@...nel.org, sashal@...nel.org,
        gregkh@...uxfoundation.org, pavel@...x.de,
        linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        alexander.shishkin@...ux.intel.com, stable@...r.kernel.org
Subject: Re: [PATCH] perf/x86/uncore: Remove unnecessary check for uncore_pmu

On Wed 2019-11-13 05:35:02, kan.liang@...ux.intel.com wrote:
> From: Kan Liang <kan.liang@...ux.intel.com>
> 
> The uncore_pmu pointer in uncore_pmu_enable/disable() is from
> container_of, which never be NULL.
> 
> Remove the unnecessary check for uncore_pmu.
> 
> Fixes: 75be6f703a14 ("perf/x86/uncore: Fix event group support")
> Reported-by: Pavel Machek <pavel@...x.de>
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
> Cc: stable@...r.kernel.org

Sorry, sent email too fast.

I agree this is good fix for mainline, but as the code is a tiny bit
ineffective but correct, I don't think we neccessarily need it in
stable.

Best regards,
							Pavel
							
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)