linux-kernel - Re: [PATCH 3/3] ARM: dts: bcm2711: Enable HWRNG support

Open Source and information security mailing list archives

Date:   Mon, 18 Nov 2019 20:44:54 +0100
From:   Stefan Wahren <wahrenst@....net>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Stephen Brennan <stephen@...nnan.io>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Scott Branden <sbranden@...adcom.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, linux-crypto@...r.kernel.org,
        Eric Anholt <eric@...olt.net>,
        Rob Herring <robh+dt@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org, Ray Jui <rjui@...adcom.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] ARM: dts: bcm2711: Enable HWRNG support

Hi,

Am 18.11.19 um 12:44 schrieb Nicolas Saenz Julienne:
> Hi Stephen,
>
> On Sun, 2019-11-17 at 23:58 -0800, Stephen Brennan wrote:
>> From: Stefan Wahren <wahrenst@....net>
>>
>> This enables hardware random number generator support for the BCM2711
>> on the Raspberry Pi 4 board.
>>
>> Signed-off-by: Stefan Wahren <wahrenst@....net>
>> Signed-off-by: Stephen Brennan <stephen@...nnan.io>
>> ---
>>  arch/arm/boot/dts/bcm2711.dtsi | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
>> index ac83dac2e6ba..2c19e5de284a 100644
>> --- a/arch/arm/boot/dts/bcm2711.dtsi
>> +++ b/arch/arm/boot/dts/bcm2711.dtsi
>> @@ -92,10 +92,9 @@ pm: watchdog@...00000 {
>>  		};
>>
>>  		rng@...04000 {
>> +			compatible = "brcm,bcm2711-rng200";
>>  			interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
>> -
>> -			/* RNG is incompatible with brcm,bcm2835-rng */
>> -			status = "disabled";
>> +			status = "okay";
>>  		};
>>
>>  		uart2: serial@...01400 {
> We inherit the reg property from bcm283x.dtsi, on which we only define a size
> of 0x10 bytes. I gather from the driver that iproc-rng200's register space is
> at least 0x28 bytes big. We should also update the 'reg' property to:
>
> 	reg = <0x7e104000 0x28>;

Thanks for sending and noticing. A proper solution would be to move the
whole rng node from bcm283x.dtsi to bcm283x-common.dtsi and define a
completely new rng node in bcm2711.dtsi.

Regards
Stefan

>
> Regards,
> Nicolas
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives