| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <MN2PR02MB6029D9F42B920927DF7813EEC14D0@MN2PR02MB6029.namprd02.prod.outlook.com>
Date: Mon, 18 Nov 2019 03:55:56 +0000
From: Manish Narani <MNARANI@...inx.com>
To: Rob Herring <robh@...nel.org>
CC: "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
Michal Simek <michals@...inx.com>,
Jolly Shah <JOLLYS@...inx.com>,
Nava kishore Manne <navam@...inx.com>,
Rajan Vaja <RAJANV@...inx.com>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, git <git@...inx.com>
Subject: RE: [PATCH v5 4/8] dt-bindings: mmc: Add optional generic properties
for mmc
Hi Rob,
> -----Original Message-----
> From: Manish Narani
> Sent: Monday, November 11, 2019 3:38 PM
> To: Rob Herring <robh@...nel.org>
> Cc: ulf.hansson@...aro.org; mark.rutland@....com;
> adrian.hunter@...el.com; Michal Simek <michals@...inx.com>; Jolly Shah
> <JOLLYS@...inx.com>; Nava kishore Manne <navam@...inx.com>; Rajan Vaja
> <RAJANV@...inx.com>; linux-mmc@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; git <git@...inx.com>
> Subject: RE: [PATCH v5 4/8] dt-bindings: mmc: Add optional generic properties
> for mmc
>
> Hi Rob,
>
>
> > -----Original Message-----
> > From: Rob Herring <robh@...nel.org>
> > Sent: Tuesday, November 5, 2019 4:44 AM
> > To: Manish Narani <MNARANI@...inx.com>
> > Cc: ulf.hansson@...aro.org; mark.rutland@....com;
> > adrian.hunter@...el.com; Michal Simek <michals@...inx.com>; Jolly Shah
> > <JOLLYS@...inx.com>; Nava kishore Manne <navam@...inx.com>; Rajan
> Vaja
> > <RAJANV@...inx.com>; linux-mmc@...r.kernel.org;
> > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> > kernel@...ts.infradead.org; git <git@...inx.com>
> > Subject: Re: [PATCH v5 4/8] dt-bindings: mmc: Add optional generic
> > properties for mmc
> >
> > On Fri, Nov 01, 2019 at 11:35:49AM +0530, Manish Narani wrote:
> > > Add optional properties for mmc hosts which are used to set clk delays
> > > for different speed modes in the controller.
> > >
> > > Signed-off-by: Manish Narani <manish.narani@...inx.com>
> > > ---
> > > .../bindings/mmc/mmc-controller.yaml | 92 +++++++++++++++++++
> > > 1 file changed, 92 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-
> controller.yaml
> > b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> > > index 080754e0ef35..87a83d966851 100644
> > > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> > > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> > > @@ -212,6 +212,98 @@ properties:
> > > description:
> > > eMMC HS400 enhanced strobe mode is supported
> > >
> > > + # Below mentioned are the clock (phase) delays which are to be
> > configured
> > > + # in the controller while switching to particular speed mode. The range
> > > + # of values are 0 to 359 degrees.
> > > +
> > > + clk-phase-legacy:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for Legacy Mode.
> > > +
> > > + clk-phase-mmc-hs:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair degrees for MMC HS.
> > > +
> > > + clk-phase-sd-hs:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for SD HS.
> > > +
> > > + clk-phase-uhs-sdr12:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for SDR12.
> > > +
> > > + clk-phase-uhs-sdr25:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for SDR25.
> > > +
> > > + clk-phase-uhs-sdr50:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for SDR50.
> > > +
> > > + clk-phase-uhs-sdr104:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for SDR104.
> > > +
> > > + clk-phase-uhs-ddr50:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for SD DDR50.
> > > +
> > > + clk-phase-mmc-ddr52:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for MMC DDR52.
> > > +
> > > + clk-phase-mmc-hs200:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for MMC HS200.
> > > +
> > > + clk-phase-mmc-hs400:
> > > + allOf:
> > > + - $ref: /schemas/types.yaml#/definitions/uint32
> > > + - minimum: 0
> > > + - maximum: 359
> > > + description:
> > > + Input/Output Clock Delay pair in degrees for MMC HS400.
> >
> > This can be condensed into:
> >
> > patternProperties:
> >
> > "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-
> > (sdr(12|25|50|104)|ddr50))$":
> >
> > Or if you want to divide them between SD and MMC ones, that would be
> > fine for me.
>
> Below change should work? Please review.
>
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -333,6 +333,16 @@ patternProperties:
> required:
> - reg
>
> + "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-
> (sdr(12|25|50|104)|ddr50))$":
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Set the clock (phase) delays which are to be configured in the
> + controller while switching to particular speed mode. These values
> + are in pair of degrees.
> +
> dependencies:
> cd-debounce-delay-ms: [ cd-gpios ]
> fixed-emmc-driver-type: [ non-removable ]
> @@ -351,6 +361,7 @@ examples:
> keep-power-in-suspend;
> wakeup-source;
> mmc-pwrseq = <&sdhci0_pwrseq>;
> + clk-phase-sd-hs = <63>, <72>;
> };
>
> - |
Any comment on above change?
Thanks,
Manish
Powered by blists - more mailing lists