linux-kernel - Re: [PATCH 1/2] coresight: funnel: Fix missing spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Nov 2019 09:15:27 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init()

On Mon, 18 Nov 2019 at 21:30, Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Nov 18, 2019 at 11:52:06AM -0700, Mathieu Poirier wrote:
> > From: Wei Yongjun <weiyongjun1@...wei.com>
> >
> > The driver allocates the spinlock but not initialize it.
> > Use spin_lock_init() on it to initialize it correctly.
> >
> > This is detected by Coccinelle semantic patch.
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> > Tested-by: Yabin Cui <yabinc@...gle.com>
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> > ---
> >  drivers/hwtracing/coresight/coresight-funnel.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Is this, and the 2/2 patch here, needed for stable releases?

No as the code they fix is new to this cycle[1].

Thanks for being inquisitive,
Mathieu

[1]. https://lkml.org/lkml/2019/11/4/726

>
> thanks,
>
> greg k-h