linux-kernel - Re: [v2] nbd:fix memory leak in nbd_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119161658.mmifoeplc5vsdt64@macbook-pro-91.dhcp.thefacebook.com>
Date:   Tue, 19 Nov 2019 11:16:58 -0500
From:   Josef Bacik <josef@...icpanda.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Sun Ke <sunke32@...wei.com>, josef@...icpanda.com,
        linux-block@...r.kernel.org, nbd@...er.debian.org,
        linux-kernel@...r.kernel.org, Mike Christie <mchristi@...hat.com>
Subject: Re: [v2] nbd:fix memory leak in nbd_get_socket()

On Tue, Nov 19, 2019 at 09:13:34AM -0700, Jens Axboe wrote:
> On 11/18/19 11:09 PM, Sun Ke wrote:
> > Before return NULL,put the sock first.
> > 
> > Cc: stable@...r.kernel.org
> > Fixes: cf1b2326b734 ("nbd: verify socket is supported during setup")
> > Signed-off-by: Sun Ke <sunke32@...wei.com>
> 
> Please always CC the author of the patch you're fixing.
> 
> Mike, Josef - we probably need to get this upstream ASAP.

Yup sorry got distracted,

Reviewed-by: Josef Bacik <josef@...icpanda.com>

Thanks,

Josef