linux-kernel - Re: [PATCH v2 1/2] perf util: Move block tui function to ui browsers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119200927.GB7364@krava>
Date:   Tue, 19 Nov 2019 21:09:27 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2 1/2] perf util: Move block tui function to ui browsers

On Mon, Nov 18, 2019 at 10:08:48PM +0800, Jin Yao wrote:
> It would be nice if we could jump to the assembler/source view
> (like the normal perf report) from total cycles view.
> 
> This patch moves the block_hists_tui_browse from block-info.c
> to ui/browsers/hists.c in order to reuse some browser codes
> (i.e do_annotate) for implementing new annotation view.
> 
>  v2:
>  ---
>  Fix the 'make NO_SLANG=1' error. (Change 'int block_hists_tui_browse()'
>  to 'static inline int block_hists_tui_browse()')
> 
> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>

for both patches

Acked-by:  Olsa <jolsa@...hat.com>

thanks,
jirka