linux-kernel - Re: [PATCH v2 1/2] perf util: Move block tui function to ui browsers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119223734.GE24290@kernel.org>
Date:   Tue, 19 Nov 2019 19:37:34 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jin Yao <yao.jin@...ux.intel.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2 1/2] perf util: Move block tui function to ui browsers

Em Tue, Nov 19, 2019 at 09:09:27PM +0100, Jiri Olsa escreveu:
> On Mon, Nov 18, 2019 at 10:08:48PM +0800, Jin Yao wrote:
> > It would be nice if we could jump to the assembler/source view
> > (like the normal perf report) from total cycles view.
> > 
> > This patch moves the block_hists_tui_browse from block-info.c
> > to ui/browsers/hists.c in order to reuse some browser codes
> > (i.e do_annotate) for implementing new annotation view.
> > 
> >  v2:
> >  ---
> >  Fix the 'make NO_SLANG=1' error. (Change 'int block_hists_tui_browse()'
> >  to 'static inline int block_hists_tui_browse()')
> > 
> > Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> 
> for both patches
> 
> Acked-by:  Olsa <jolsa@...hat.com>

Thanks, tested and applied.

- Arnaldo