linux-kernel - Re: [PATCH] fork: fix pidfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191120002145.skgtkx2f5dxagx4f@wittgenstein>
Date:   Wed, 20 Nov 2019 01:21:47 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH] fork: fix pidfd_poll()'s return type

On Wed, Nov 20, 2019 at 01:07:22AM +0100, Luc Van Oostenryck wrote:
> pidfd_poll() is defined as returning 'unsigned int' but the
> .poll method is declared as returning '__poll_t', a bitwise type.
> 
> Fix this by using the proper return type and using the EPOLL
> constants instead of the POLL ones, as required for __poll_t.
> 
> CC: Joel Fernandes (Google) <joel@...lfernandes.org>
> CC: Christian Brauner <christian@...uner.io>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>

Yeah, that makes sense. Thanks.

This only misses two tags:

Fixes: b53b0b9d9a61 ("pidfd: add polling support")
Cc: stable@...r.kernel.org # 5.3

Can you add these two tags to the commit message for v1 and resend with
stable@...r.kernel.org Cced, please?

Otherwise:
Reviewed-by: Christian Brauner <christian.brauner@...ntu.com>