linux-kernel - Re: [PATCH] scsi: Fix Kconfig indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 20 Nov 2019 14:43:23 +0000
From:   John Garry <john.garry@...wei.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke <hare@...e.com>,
        "QLogic-Storage-Upstream@...ium.com" 
        <QLogic-Storage-Upstream@...ium.com>,
        Don Brace <don.brace@...rosemi.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "esc.storagedev@...rosemi.com" <esc.storagedev@...rosemi.com>
Subject: Re: [PATCH] scsi: Fix Kconfig indentation

On 20/11/2019 13:39, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> 	$ sed -e 's/^        /\t/' -i */Kconfig
> 

./scripts/checkpatch.pl -f --strict drivers/scsi/Kconfig

didn't warn of indentation issues for me. To stop this reoccurring, 
could that be added?

Thanks,
John


> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>   drivers/scsi/Kconfig                 | 22 +++++++++++-----------
>   drivers/scsi/aic7xxx/Kconfig.aic7xxx | 14 +++++++-------
>   drivers/scsi/pcmcia/Kconfig          |  2 +-
>   drivers/scsi/qedf/Kconfig            |  4 ++--
>   drivers/scsi/smartpqi/Kconfig        |  8 ++++----
>   5 files changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 90cf4691b8c3..de6b99573f9e 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1166,8 +1166,8 @@ config SCSI_LPFC
>   	depends on NVME_FC || NVME_FC=n
>   	select CRC_T10DIF
>   	---help---
> -          This lpfc driver supports the Emulex LightPulse
> -          Family of Fibre Channel PCI host adapters.
> +	  This lpfc driver supports the Emulex LightPulse
> +	  Family of Fibre Channel PCI host adapters.
>   
>   config SCSI_LPFC_DEBUG_FS
>   	bool "Emulex LightPulse Fibre Channel debugfs Support"
> @@ -1480,14 +1480,14 @@ config ZFCP
>   	depends on S390 && QDIO && SCSI
>   	depends on SCSI_FC_ATTRS
>   	help
> -          If you want to access SCSI devices attached to your IBM eServer
> -          zSeries by means of Fibre Channel interfaces say Y.
> -          For details please refer to the documentation provided by IBM at
> -          <http://oss.software.ibm.com/developerworks/opensource/linux390>
> +	  If you want to access SCSI devices attached to your IBM eServer
> +	  zSeries by means of Fibre Channel interfaces say Y.
> +	  For details please refer to the documentation provided by IBM at
> +	  <http://oss.software.ibm.com/developerworks/opensource/linux390>
>   
> -          This driver is also available as a module. This module will be
> -          called zfcp. If you want to compile it as a module, say M here
> -          and read <file:Documentation/kbuild/modules.rst>.
> +	  This driver is also available as a module. This module will be
> +	  called zfcp. If you want to compile it as a module, say M here
> +	  and read <file:Documentation/kbuild/modules.rst>.
>   
>   config SCSI_PMCRAID
>   	tristate "PMC SIERRA Linux MaxRAID adapter support"
> @@ -1518,8 +1518,8 @@ config SCSI_VIRTIO
>   	tristate "virtio-scsi support"
>   	depends on VIRTIO
>   	help
> -          This is the virtual HBA driver for virtio.  If the kernel will
> -          be used in a virtual machine, say Y or M.
> +	  This is the virtual HBA driver for virtio.  If the kernel will
> +	  be used in a virtual machine, say Y or M.
>   
>   source "drivers/scsi/csiostor/Kconfig"
>   
> diff --git a/drivers/scsi/aic7xxx/Kconfig.aic7xxx b/drivers/scsi/aic7xxx/Kconfig.aic7xxx
> index 3546b8cc401f..4ed44ba4a55b 100644
> --- a/drivers/scsi/aic7xxx/Kconfig.aic7xxx
> +++ b/drivers/scsi/aic7xxx/Kconfig.aic7xxx
> @@ -71,20 +71,20 @@ config AIC7XXX_DEBUG_ENABLE
>   	driver errors.
>   
>   config AIC7XXX_DEBUG_MASK
> -        int "Debug code enable mask (2047 for all debugging)"
> -        depends on SCSI_AIC7XXX
> -        default "0"
> -        help
> +	int "Debug code enable mask (2047 for all debugging)"
> +	depends on SCSI_AIC7XXX
> +	default "0"
> +	help
>   	Bit mask of debug options that is only valid if the
>   	CONFIG_AIC7XXX_DEBUG_ENABLE option is enabled.  The bits in this mask
>   	are defined in the drivers/scsi/aic7xxx/aic7xxx.h - search for the
>   	variable ahc_debug in that file to find them.
>   
>   config AIC7XXX_REG_PRETTY_PRINT
> -        bool "Decode registers during diagnostics"
> -        depends on SCSI_AIC7XXX
> +	bool "Decode registers during diagnostics"
> +	depends on SCSI_AIC7XXX
>   	default y
> -        help
> +	help
>   	Compile in register value tables for the output of expanded register
>   	contents in diagnostics.  This make it much easier to understand debug
>   	output without having to refer to a data book and/or the aic7xxx.reg
> diff --git a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig
> index dc9b74c9348a..a7920fc95e7d 100644
> --- a/drivers/scsi/pcmcia/Kconfig
> +++ b/drivers/scsi/pcmcia/Kconfig
> @@ -56,7 +56,7 @@ config PCMCIA_NINJA_SCSI
>   	    [I-O DATA (OEM) (version string: "IO DATA","CBSC16       ","1")]
>   	    I-O DATA CBSC-II
>   	    [Kyusyu Matsushita Kotobuki (OEM)
> -               (version string: "KME    ","SCSI-CARD-001","1")]
> +	       (version string: "KME    ","SCSI-CARD-001","1")]
>   	    KME KXL-820AN's card
>   	    HP M820e CDRW's card
>   	    etc.
> diff --git a/drivers/scsi/qedf/Kconfig b/drivers/scsi/qedf/Kconfig
> index 7cd993be4e57..80328dbd44c9 100644
> --- a/drivers/scsi/qedf/Kconfig
> +++ b/drivers/scsi/qedf/Kconfig
> @@ -3,8 +3,8 @@ config QEDF
>   	tristate "QLogic QEDF 25/40/100Gb FCoE Initiator Driver Support"
>   	depends on PCI && SCSI
>   	depends on QED
> -        depends on LIBFC
> -        depends on LIBFCOE
> +	depends on LIBFC
> +	depends on LIBFCOE
>   	select QED_LL2
>   	select QED_FCOE
>   	---help---
> diff --git a/drivers/scsi/smartpqi/Kconfig b/drivers/scsi/smartpqi/Kconfig
> index bc6506884e3b..456ec474fa17 100644
> --- a/drivers/scsi/smartpqi/Kconfig
> +++ b/drivers/scsi/smartpqi/Kconfig
> @@ -50,7 +50,7 @@ config SCSI_SMARTPQI
>   	To compile this driver as a module, choose M here: the
>   	module will be called smartpqi.
>   
> -        Note: the aacraid driver will not manage a smartpqi
> -              controller. You need to enable smartpqi for smartpqi
> -              controllers. For more information, please see
> -              Documentation/scsi/smartpqi.txt
> +	Note: the aacraid driver will not manage a smartpqi
> +	      controller. You need to enable smartpqi for smartpqi
> +	      controllers. For more information, please see
> +	      Documentation/scsi/smartpqi.txt
>