linux-kernel - Re: [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate hpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdba31c8-d0c0-83a8-62d1-c04c1e894218@redhat.com>
Date:   Wed, 20 Nov 2019 16:07:38 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>,
        n-horiguchi@...jp.nec.com, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate
 hpage

On 18.11.19 09:20, Wei Yang wrote:
> hpage is not changed.
> 
> Signed-off-by: Wei Yang <richardw.yang@...ux.intel.com>
> ---
>   mm/memory-failure.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 392ac277b17d..9784f4339ae7 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1319,7 +1319,6 @@ int memory_failure(unsigned long pfn, int flags)
>   		}
>   		unlock_page(p);
>   		VM_BUG_ON_PAGE(!page_count(p), p);
> -		hpage = compound_head(p);
>   	}
>   
>   	/*
> 

I am *absolutely* no transparent huge page expert (sorry :) ), but won't 
the split_huge_page(p) eventually split the compound page, such that 
compound_head(p) will return something else after that call?

-- 

Thanks,

David / dhildenb