linux-kernel - RE: [PATCH v4 10/13] exfat: add nls operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Nov 2019 17:19:30 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Markus Elfring'" <Markus.Elfring@....de>
Cc:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        "'Christoph Hellwig'" <hch@....de>,
        "'Daniel Wagner'" <dwagner@...e.de>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Nikolay Borisov'" <nborisov@...e.com>,
        "'Sungjong Seo'" <sj1557.seo@...sung.com>,
        'Valdis Klētnieks' <valdis.kletnieks@...edu>,
        <linkinjeon@...il.com>, <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH v4 10/13] exfat: add nls operations

> > +	exfat_msg(sb, KERN_ERR,
> > +			"failed to load upcase table (idx : 0x%08x, chksum :
> 0x%08x, utbl_chksum : 0x%08x)\n",
> > +			index, checksum, utbl_checksum);
> > +
> > +	ret = -EINVAL;
> 
> Can a blank line be omitted between the message and the error code?
Okay.
> 
> 
> > +release_bh:
> > +	brelse(bh);
> > +	exfat_free_upcase_table(sb);
> > +	return ret;
> > +}
> 
> I got the impression that the resource management is still questionable
> for this function implementation.
> 
> 1. Now I suggest to move the call of the function “brelse” to the end
>    of the while loop. The label “release_bh” would be renamed to “free_table”
> then.
Okay.
> 
> 2. Can a variable initialisation be converted to the assignment “ret = -EIO;”
>    in an if branch?
Okay, Will fix it on v5.

Thanks for your review!
> 
> Regards,
> Markus