linux-kernel - Re: [PATCH] media: i2c: mt9v032: fix enum mbus codes and frame sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191121082027.GJ4958@pendragon.ideasonboard.com>
Date:   Thu, 21 Nov 2019 10:20:27 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Eugen.Hristev@...rochip.com
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        sakari.ailus@....fi
Subject: Re: [PATCH] media: i2c: mt9v032: fix enum mbus codes and frame sizes

Hi Eugen,

Thank you for the patch.

On Thu, Nov 21, 2019 at 07:55:24AM +0000, Eugen.Hristev@...rochip.com wrote:
> From: Eugen Hristev <eugen.hristev@...rochip.com>
> 
> This driver supports both the mt9v032 (color) and the mt9v022 (mono) sensors.
> Depending on which sensor is used, the format from the sensor is different.
> The format.code inside the dev struct holds this information.
> The enum mbus and enum frame sizes need to take into account both type of
> sensors, not just the color one.
> To solve this, use the format.code in these functions instead of the
> hardcoded bayer color format (which is only used for mt9v032).
> 
> Suggested-by: Wenyou Yang <wenyou.yang@...rochip.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/i2c/mt9v032.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
> index 4b9b98c..5bd3ae82 100644
> --- a/drivers/media/i2c/mt9v032.c
> +++ b/drivers/media/i2c/mt9v032.c
> @@ -428,10 +428,12 @@ static int mt9v032_enum_mbus_code(struct v4l2_subdev *subdev,
>  				  struct v4l2_subdev_pad_config *cfg,
>  				  struct v4l2_subdev_mbus_code_enum *code)
>  {
> +	struct mt9v032 *mt9v032 = to_mt9v032(subdev);
> +
>  	if (code->index > 0)
>  		return -EINVAL;
>  
> -	code->code = MEDIA_BUS_FMT_SGRBG10_1X10;
> +	code->code = mt9v032->format.code;
>  	return 0;
>  }
>  
> @@ -439,7 +441,11 @@ static int mt9v032_enum_frame_size(struct v4l2_subdev *subdev,
>  				   struct v4l2_subdev_pad_config *cfg,
>  				   struct v4l2_subdev_frame_size_enum *fse)
>  {
> -	if (fse->index >= 3 || fse->code != MEDIA_BUS_FMT_SGRBG10_1X10)
> +	struct mt9v032 *mt9v032 = to_mt9v032(subdev);
> +
> +	if (fse->index >= 3)
> +		return -EINVAL;
> +	if (mt9v032->format.code != fse->code)
>  		return -EINVAL;
>  
>  	fse->min_width = MT9V032_WINDOW_WIDTH_DEF / (1 << fse->index);

-- 
Regards,

Laurent Pinchart