linux-kernel - Re: [PATCH v4 02/13] exfat: add super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <177371e7-9f52-407c-4f9b-ec9efb15f4a8@web.de>
Date:   Thu, 21 Nov 2019 10:40:39 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        Daniel Wagner <dwagner@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nikolay Borisov <nborisov@...e.com>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Valdis Klētnieks <valdis.kletnieks@...edu>,
        linkinjeon@...il.com
Subject: Re: [PATCH v4 02/13] exfat: add super block operations

…
> +++ b/fs/exfat/super.c
…
> +static int __init init_exfat_fs(void)
> +{
…
> +	err = -ENOMEM;
> +	exfat_inode_cachep = kmem_cache_create("exfat_inode_cache",
> +			sizeof(struct exfat_inode_info),
> +			0, SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD,
> +			exfat_inode_init_once);
> +	if (!exfat_inode_cachep)
> +		goto shutdown_cache;

Should such an error code assignment be performed only after a failed function call?

Regards,
Markus