linux-kernel - Re: [PATCH v7 2/9] vmx: spp: Add control flags for Sub-Page Protection(SPP)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6e71e7b-b708-211c-24b7-8ffe03a52842@redhat.com>
Date:   Thu, 21 Nov 2019 11:04:51 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yang Weijiang <weijiang.yang@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmattson@...gle.com,
        sean.j.christopherson@...el.com
Cc:     yu.c.zhang@...ux.intel.com, alazar@...defender.com,
        edwin.zhai@...el.com
Subject: Re: [PATCH v7 2/9] vmx: spp: Add control flags for Sub-Page
 Protection(SPP)

On 19/11/19 09:49, Yang Weijiang wrote:
> @@ -228,6 +228,7 @@
>  #define X86_FEATURE_FLEXPRIORITY	( 8*32+ 2) /* Intel FlexPriority */
>  #define X86_FEATURE_EPT			( 8*32+ 3) /* Intel Extended Page Table */
>  #define X86_FEATURE_VPID		( 8*32+ 4) /* Intel Virtual Processor ID */
> +#define X86_FEATURE_SPP			( 8*32+ 5) /* Intel EPT-based Sub-Page Write Protection */

Please do not include X86_FEATURE_SPP.  In general I don't like the VMX
features word, but apart from that SPP is not a feature that affects all
VMs in the same way as EPT or FlexPriority.

Paolo