linux-kernel - Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6898c9fe-6cd7-8820-78c0-9fc4969b48f1@redhat.com>
Date:   Thu, 21 Nov 2019 11:32:19 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yang Weijiang <weijiang.yang@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmattson@...gle.com,
        sean.j.christopherson@...el.com
Cc:     yu.c.zhang@...ux.intel.com, alazar@...defender.com,
        edwin.zhai@...el.com
Subject: Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

On 19/11/19 09:49, Yang Weijiang wrote:
> +			if (old_spte != spp_spte) {
> +				spp_spte_set(iter.sptep, spp_spte);
> +				//kvm_make_request(KVM_REQ_TLB_FLUSH, vcpu);
> +				kvm_flush_remote_tlbs(vcpu->kvm);
> +			}

Please do not leave commented code in the middle of the series.

Paolo