linux-kernel - Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b0da087-8ce0-2b01-5a1a-4d8c5f319d33@redhat.com>
Date:   Thu, 21 Nov 2019 11:38:18 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yang Weijiang <weijiang.yang@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmattson@...gle.com,
        sean.j.christopherson@...el.com
Cc:     yu.c.zhang@...ux.intel.com, alazar@...defender.com,
        edwin.zhai@...el.com
Subject: Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

On 19/11/19 09:49, Yang Weijiang wrote:
> +static int is_spp_shadow_present(u64 pte)
> +{
> +	return pte & PT_PRESENT_MASK;
> +}
> +

This should not be needed, is_shadow_present_pte works well for SPP PTEs
as well (and in fact you're already using it here and there, so it's
confusing to have both).

Paolo