linux-kernel - Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121145505.GC17169@local-michael-cet-test>
Date:   Thu, 21 Nov 2019 22:55:05 +0800
From:   Yang Weijiang <weijiang.yang@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Yang Weijiang <weijiang.yang@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmattson@...gle.com,
        sean.j.christopherson@...el.com, yu.c.zhang@...ux.intel.com,
        alazar@...defender.com, edwin.zhai@...el.com
Subject: Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

On Thu, Nov 21, 2019 at 11:38:18AM +0100, Paolo Bonzini wrote:
> On 19/11/19 09:49, Yang Weijiang wrote:
> > +static int is_spp_shadow_present(u64 pte)
> > +{
> > +	return pte & PT_PRESENT_MASK;
> > +}
> > +
> 
> This should not be needed, is_shadow_present_pte works well for SPP PTEs
> as well (and in fact you're already using it here and there, so it's
> confusing to have both).
>
OK, will remove it.
> Paolo