linux-kernel - Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121145736.GD17169@local-michael-cet-test>
Date:   Thu, 21 Nov 2019 22:57:36 +0800
From:   Yang Weijiang <weijiang.yang@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Yang Weijiang <weijiang.yang@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmattson@...gle.com,
        sean.j.christopherson@...el.com, yu.c.zhang@...ux.intel.com,
        alazar@...defender.com, edwin.zhai@...el.com
Subject: Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

On Thu, Nov 21, 2019 at 11:32:19AM +0100, Paolo Bonzini wrote:
> On 19/11/19 09:49, Yang Weijiang wrote:
> > +			if (old_spte != spp_spte) {
> > +				spp_spte_set(iter.sptep, spp_spte);
> > +				//kvm_make_request(KVM_REQ_TLB_FLUSH, vcpu);
> > +				kvm_flush_remote_tlbs(vcpu->kvm);
> > +			}
> 
> Please do not leave commented code in the middle of the series.

Oops, I should have removed them, thanks for pointing it out.
> Paolo