linux-kernel - Re: [PATCH v5 10/13] exfat: add nls operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <147eac54-5846-ffe1-4b6b-ebf611d1252b@web.de>
Date:   Mon, 25 Nov 2019 09:50:32 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Daniel Wagner <dwagner@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nikolay Borisov <nborisov@...e.com>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Valdis Klētnieks <valdis.kletnieks@...edu>,
        linkinjeon@...il.com
Subject: Re: [PATCH v5 10/13] exfat: add nls operations

…
> +++ b/fs/exfat/nls.c
…
> +static int exfat_load_upcase_table(struct super_block *sb,
> +		sector_t sector, unsigned long long num_sectors,
> +		unsigned int utbl_checksum)
> +{
…
> +	unsigned int i, index = 0, checksum = 0;
…
> +			checksum = ((checksum & 1) ? 0x80000000 : 0) +
> +				(checksum >> 1) +
> +				*(((unsigned char *)bh->b_data) + (i + 1));
…
> +	if (index >= 0xFFFF && utbl_checksum == checksum)
> +		return 0;

* Can it be that a type other than “int” would be more portable
  for the desired data processing at these source code places?

* How do you think about to use more meaningful identifiers for
  two of the shown literals?

Regards,
Markus