linux-kernel - Re: [PATCH v5 04/13] exfat: add directory operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fb7a74f-abf4-0842-5602-d8e5706fc75d@web.de>
Date:   Mon, 25 Nov 2019 10:26:03 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Daniel Wagner <dwagner@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nikolay Borisov <nborisov@...e.com>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Valdis Klētnieks <valdis.kletnieks@...edu>,
        linkinjeon@...il.com
Subject: Re: [PATCH v5 04/13] exfat: add directory operations

…
> +int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info *ei,
> +		struct exfat_chain *p_dir, struct exfat_uni_name *p_uniname,
> +		int num_entries, unsigned int type)
> +{
…
> +	unsigned short entry_uniname[16], *uniname = NULL, unichar;

Would you like to reduce the scope for these variables according to an if branch
for the condition “entry_type == TYPE_EXTEND”?


…
> +	struct buffer_head *bh = NULL;

* How do you think about to move the definition for this variable
  to the beginning of the for loop?

* Can this pointer initialisation be omitted?

Regards,
Markus