linux-kernel - Re: [PATCH] arm: exynos_config: Restore debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f6a5924-58f9-aafb-18c5-c749ad355a02@samsung.com>
Date:   Mon, 25 Nov 2019 15:30:39 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Kusanagi Kouichi <slash@...auone-net.jp>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] arm: exynos_config: Restore debugfs support


Hi,

On 11/25/19 1:55 PM, Marek Szyprowski wrote:
> Commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS dependency")
> removed the dependency between DEBUG_FS and TRACING, so DEBUG_FS is no
> longer enabled in default builds. Enable it again manually, as it provides
> a lots of useful data for automated testing tools.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)

It seems that commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
dependency") disabled DEBUG_FS also in some other ARM defconfigs.

For some of them it may be a correct change but a preferred way to
introduce such changes would be to:

- add explicit CONFIG_DEBUG_FS=y instances to all affected defconfigs
  while removing DEBUG_FS selection from TRACING config item

- let platform maintainers disable DEBUG_FS manually in corresponding
  defconfigs later if desirable

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index e7e4bb5ad8d5..fde84f123fbb 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -350,6 +350,7 @@ CONFIG_PRINTK_TIME=y
>  CONFIG_DYNAMIC_DEBUG=y
>  CONFIG_DEBUG_INFO=y
>  CONFIG_MAGIC_SYSRQ=y
> +CONFIG_DEBUG_FS=y
>  CONFIG_DEBUG_KERNEL=y
>  CONFIG_SOFTLOCKUP_DETECTOR=y
>  # CONFIG_DETECT_HUNG_TASK is not set