linux-kernel - Re: [PATCH] arm: exynos_config: Restore debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191125093932.4a111dc8@gandalf.local.home>
Date:   Mon, 25 Nov 2019 09:39:32 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Kusanagi Kouichi <slash@...auone-net.jp>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH] arm: exynos_config: Restore debugfs support

On Mon, 25 Nov 2019 15:30:39 +0100
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> wrote:

> It seems that commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> dependency") disabled DEBUG_FS also in some other ARM defconfigs.
> 
> For some of them it may be a correct change but a preferred way to
> introduce such changes would be to:
> 
> - add explicit CONFIG_DEBUG_FS=y instances to all affected defconfigs
>   while removing DEBUG_FS selection from TRACING config item
> 

I strongly disagree. It was wrong to assume DEBUG_FS is attached to
TRACING. If someone wanted DEBUG_FS in their def config, they should
have added it specifically. The addition of DEBUG_FS to defconfigs no
way belongs to the patch that removed DEBUG_FS from TRACING.

-- Steve


> - let platform maintainers disable DEBUG_FS manually in corresponding
>   defconfigs later if desirable