linux-kernel - [PATCH] gpu: ttm: add _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191126101319.79476-1-jbi.octave@gmail.com>
Date:   Tue, 26 Nov 2019 10:13:19 +0000
From:   Jules Irenge <jbi.octave@...il.com>
To:     christian.koenig@....com
Cc:     ray.huang@....com, airlied@...ux.ie, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Boqun.Feng@...rosoft.com, Andrea.Parri@...rosoft.com,
        Jules Irenge <jbi.octave@...il.com>
Subject: [PATCH] gpu: ttm: add __releases function

Add releases() function to fix context imbalance.
 Issue detected by sparse tool.
warning: context imbalance in ttm_bo_cleanup_refs - unexpected unlock

Signed-off-by: Jules Irenge <jbi.octave@...il.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 98819462f025..c87481d667a9 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -544,7 +544,7 @@ static void ttm_bo_cleanup_refs_or_queue(struct ttm_buffer_object *bo)
 
 static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo,
 			       bool interruptible, bool no_wait_gpu,
-			       bool unlock_resv)
+			       bool unlock_resv) __releases(&glob->lru_lock)
 {
 	struct ttm_bo_global *glob = bo->bdev->glob;
 	struct dma_resv *resv;
-- 
2.23.0