linux-kernel - Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com>
Date:   Tue, 26 Nov 2019 07:31:56 -0800
From:   Tom Rix <trix@...hat.com>
To:     Joerg Vehlow <lkml@...coder.de>, linux-kernel@...r.kernel.org,
        bigeasy@...utronix.de
Cc:     Joerg Vehlow <joerg.vehlow@...-tech.de>
Subject: Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock

Why remove the #ifdef CONFIG_PREEMPT.. ?


> +	spin_lock_irqsave(&trans->queue.lock, flags);
>  	skb_queue_splice_init(&trans->queue, &queue);
> +	spin_unlock_irqrestore(&trans->queue.lock, flags);
>  

Fine otherwise.

Tom