linux-kernel - Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Nov 2019 08:35:01 +0100
From:   Joerg Vehlow <lkml@...coder.de>
To:     Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        bigeasy@...utronix.de
Cc:     Joerg Vehlow <joerg.vehlow@...-tech.de>
Subject: Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock

Hi Tom,

I didn't remove it, I just posted my patch again.
I think it is up to the maintainers to decide if
it is required or not. Most people using the rt
patches will probably have PREEMPT_RT_FULL enabled anyway.
It will never be integrated into mainline kernel, because
the bug is already fixed in 5.0.19.

Jörg

Am 26.11.2019 um 16:31 schrieb Tom Rix:
> Why remove the #ifdef CONFIG_PREEMPT.. ?
>
>
>> +	spin_lock_irqsave(&trans->queue.lock, flags);
>>   	skb_queue_splice_init(&trans->queue, &queue);
>> +	spin_unlock_irqrestore(&trans->queue.lock, flags);
>>   
> Fine otherwise.
>
> Tom
>
>