linux-kernel - Re: [PATCH 4.19 000/306] 4.19.87-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191128080501.GA3384654@kroah.com>
Date:   Thu, 28 Nov 2019 09:05:01 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Daniel Díaz <daniel.diaz@...aro.org>
Cc:     open list <linux-kernel@...r.kernel.org>,
        torvalds@...ux-foundation.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        lkft-triage@...ts.linaro.org,
        linux- stable <stable@...r.kernel.org>
Subject: Re: [PATCH 4.19 000/306] 4.19.87-stable review

On Wed, Nov 27, 2019 at 06:27:55PM -0600, Daniel Díaz wrote:
> Hello!
> 
> 
> On Wed, 27 Nov 2019 at 14:55, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > This is the start of the stable review cycle for the 4.19.87 release.
> > There are 306 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 29 Nov 2019 20:18:09 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.87-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> We're seeing this build failure on 4.19 (and 4.14) on x86 32-bits:
> > In file included from /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/export.h:45:0,
> >                  from /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/linkage.h:7,
> >                  from /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/preempt.h:10,
> >                  from /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/spinlock.h:51,
> >                  from /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/mm/cpu_entry_area.c:3:
> > In function 'setup_cpu_entry_area_ptes',
> >     inlined from 'setup_cpu_entry_areas' at /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/mm/cpu_entry_area.c:209:2:
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/compiler.h:348:38: error: call to '__compiletime_assert_192' declared with attribute error: BUILD_BUG_ON failed: (CPU_ENTRY_AREA_PAGES+1)*PAGE_SIZE != CPU_ENTRY_AREA_MAP_SIZE
> >   _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
> >                                       ^
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/compiler.h:329:4: note: in definition of macro '__compiletime_assert'
> >     prefix ## suffix();    \
> >     ^~~~~~
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/compiler.h:348:2: note: in expansion of macro '_compiletime_assert'
> >   _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
> >   ^~~~~~~~~~~~~~~~~~~
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/build_bug.h:45:37: note: in expansion of macro 'compiletime_assert'
> >  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> >                                      ^~~~~~~~~~~~~~~~~~
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/include/linux/build_bug.h:69:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
> >   BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
> >   ^~~~~~~~~~~~~~~~
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/mm/cpu_entry_area.c:192:2: note: in expansion of macro 'BUILD_BUG_ON'
> >   BUILD_BUG_ON((CPU_ENTRY_AREA_PAGES+1)*PAGE_SIZE != CPU_ENTRY_AREA_MAP_SIZE);
> >   ^~~~~~~~~~~~
> 
> Bisection points to "x86/cpu_entry_area: Add guard page for entry
> stack on 32bit" (e50622b4a1, also present in 4.14.y as 880a98c339).

Ugh, I was hoping that 32bit stuff "just worked".  I'll take a look at
the whole series later today and try to work to backport some of the
known-missing parts of that series.

thanks,

greg k-h