linux-kernel - Re: [PATCH v1 1/4] powerpc/fixmap: don't clear fixmap area in paging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51c97c23-251d-90d9-0c52-41ef55c9f4c9@c-s.fr>
Date:   Thu, 28 Nov 2019 09:06:52 +0100
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Michael Ellerman <patch-notifications@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>, npiggin@...il.com,
        hch@...radead.org
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/4] powerpc/fixmap: don't clear fixmap area in
 paging_init()



Le 27/11/2019 à 15:43, Christophe Leroy a écrit :
> 
> 
> Le 26/11/2019 à 02:13, Michael Ellerman a écrit :
>> On Thu, 2019-09-12 at 13:49:41 UTC, Christophe Leroy wrote:
>>> fixmap is intended to map things permanently like the IMMR region on
>>> FSL SOC (8xx, 83xx, ...), so don't clear it when initialising paging()
>>>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
>>
>> Applied to powerpc next, thanks.
>>
>> https://git.kernel.org/powerpc/c/f2bb86937d86ebcb0e52f95b6d19aba1d850e601
>>
> 
> Hi,
> 
> What happened ?
> 
> It looks like it is gone in today's powerpc next.
> 

I see it back today in powerpc/merge, thanks.

The issue is it is crashing with HIGHMEM, indeed exactly the same as you 
saw with "[PATCH] powerpc/8xx: Fix permanently mapped IMMR region.", 
since that was exactly the same code.

I sent a fix for it, and I also rebased "[PATCH] powerpc/8xx: Fix 
permanently mapped IMMR region." into v2 to exclude from it the already 
merged part.

It would be wise if you could merge both.

Thanks
Christophe