linux-kernel - Re: [PATCH v7 0/2] perf: add support for logging debug messages to file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191128150424.r6zvv3jwlegjkhcb@mail.google.com>
Date:   Thu, 28 Nov 2019 15:04:25 +0000
From:   Changbin Du <changbin.du@...il.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Changbin Du <changbin.du@...il.com>, Jiri Olsa <jolsa@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/2] perf: add support for logging debug messages to
 file

On Tue, Nov 26, 2019 at 12:19:11PM -0800, Andi Kleen wrote:
> Changbin Du <changbin.du@...il.com> writes:
> 
> > When in TUI mode, it is impossible to show all the debug messages to
> > console. This make it hard to debug perf issues using debug messages.
> > This patch adds support for logging debug messages to file to resolve
> > this problem.
> 
> This was already solved in
> 
> commit f78eaef0e0493f6068777a246b9c4d9d5cf2b7aa
> Author: Andi Kleen <ak@...ux.intel.com>
> Date:   Fri Nov 21 13:38:00 2014 -0800
> 
>     perf tools: Allow to force redirect pr_debug to stderr.
> 
>     When debugging the tui browser I find it useful to redirect the
>     debug
>         log into a file. Currently it's always forced to the message
>     line.
> 
>     Add an option to force it to stderr. Then it can be easily
>     redirected.
>     
> You can do
> 
> perf report --debug stderr 2> file ...
>
Yes, this is a good alternate approach with existing code. I still think
a new option 'file' is not bad. And later maybe we can ouput debug messages
to file only while errors ouput to both.

> -Andi

-- 
Cheers,
Changbin Du