linux-kernel - Re: [PATCH 4.4 093/132] sock: Reset dst when changing sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191129080450.GA3559797@kroah.com>
Date:   Fri, 29 Nov 2019 09:04:50 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org,
        David Barmann <david.barmann@...ckpath.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.4 093/132] sock: Reset dst when changing sk_mark via
 setsockopt

On Wed, Nov 27, 2019 at 09:31:24PM +0100, Greg Kroah-Hartman wrote:
> From: David Barmann <david.barmann@...ckpath.com>
> 
> [ Upstream commit 50254256f382c56bde87d970f3d0d02fdb76ec70 ]
> 
> When setting the SO_MARK socket option, if the mark changes, the dst
> needs to be reset so that a new route lookup is performed.
> 
> This fixes the case where an application wants to change routing by
> setting a new sk_mark.  If this is done after some packets have already
> been sent, the dst is cached and has no effect.
> 
> Signed-off-by: David Barmann <david.barmann@...ckpath.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  net/core/sock.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

This patch breaks a bunch of runtime tests in the Android ecosystem,
that somehow all successfully run just fine with kernels newer than 5.0
where this patch showed up in, so I think this is an "incomplete
backport".

Because of this, I'm going to drop this from the stable trees now.

thanks,

greg k-h