linux-kernel - Re: [PATCH] mips: Fix gettimeofday() in the vdso library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Nov 2019 16:09:51 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     Paul Burton <paulburton@...nel.org>,
        mips-creator-ci20-dev@...glegroups.com,
        letux-kernel@...nphoenux.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: Fix gettimeofday() in the vdso library


> Am 29.11.2019 um 15:58 schrieb Vincenzo Frascino <vincenzo.frascino@....com>:
> 
> On 11/29/19 2:52 PM, H. Nikolaus Schaller wrote:
>> 
>>> Am 29.11.2019 um 15:36 schrieb Vincenzo Frascino <vincenzo.frascino@....com>:
>>> 
>>> The libc provides a discovery mechanism for vDSO library and its
>>> symbols. When a symbol is not exposed by the vDSOs the libc falls back
>>> on the system calls.
>>> 
>>> With the introduction of the unified vDSO library on mips this behavior
>>> is not honored anymore by the kernel in the case of gettimeofday().
>>> 
>>> The issue has been noticed and reported due to a dhclient failure on the
>>> CI20 board:
>>> 
>>> root@...ux:~# dhclient
>>> ../../../../lib/isc/unix/time.c:200: Operation not permitted
>>> root@...ux:~#
>>> 
>>> Restore the original behavior fixing gettimeofday() in the vDSO library.
>>> 
>>> Cc: Paul Burton <paulburton@...nel.org>
>>> Reported-by: H. Nikolaus Schaller <hns@...delico.com>
>>> Testes-by: H. Nikolaus Schaller <hns@...delico.com> # CI20 with JZ4780
>> ^^^ funny typo... -> Tested-by:
> 
> Ops, I copy-pasted it from your email ;) Can't trust you ;)

No :)

Well, typos happen and nobody seems to notice. My favourite:

5f9e832c137075045d15cd6899ab0505cfb2ca4b

BR,
Nikolaus