linux-kernel - Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191129150757.GA980@Air-de-Roger>
Date:   Fri, 29 Nov 2019 16:07:57 +0100
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     "Durrant, Paul" <pdurrant@...zon.com>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>,
        Jens Axboe <axboe@...nel.dk>, Juergen Gross <jgross@...e.com>,
        <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
 unloaded

On Fri, Nov 29, 2019 at 03:02:37PM +0000, Durrant, Paul wrote:
> > -----Original Message-----
> > From: Roger Pau Monné <roger.pau@...rix.com>
> > Sent: 29 November 2019 15:00
> > To: Durrant, Paul <pdurrant@...zon.com>
> > Cc: linux-block@...r.kernel.org; linux-kernel@...r.kernel.org; xen-
> > devel@...ts.xenproject.org; Konrad Rzeszutek Wilk
> > <konrad.wilk@...cle.com>; Jens Axboe <axboe@...nel.dk>
> > Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
> > unloaded
> > 
> > On Fri, Nov 29, 2019 at 01:43:06PM +0000, Paul Durrant wrote:
> > > Add a module_exit() to perform the necessary clean-up.
> > >
> > > Signed-off-by: Paul Durrant <pdurrant@...zon.com>
> > 
> > LGTM:
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@...rix.com>
> > 
> 
> Thanks.
> 
> > AFAICT we should make sure this is not committed before patch 1, or
> > else you could unload a blkback module that's still in use?
> > 
> 
> Yes, that's correct.

Given this is a very small change, and not really block related I
think it would be better for both patches to be committed from the Xen
tree, if Jens, Juergen and Boris agree.

Thanks, Roger.