linux-kernel - Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191129150006.GZ980@Air-de-Roger>
Date:   Fri, 29 Nov 2019 16:00:06 +0100
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Paul Durrant <pdurrant@...zon.com>
CC:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
 unloaded

On Fri, Nov 29, 2019 at 01:43:06PM +0000, Paul Durrant wrote:
> Add a module_exit() to perform the necessary clean-up.
> 
> Signed-off-by: Paul Durrant <pdurrant@...zon.com>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@...rix.com>

AFAICT we should make sure this is not committed before patch 1, or
else you could unload a blkback module that's still in use?

Thanks, Roger.