linux-kernel - Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5389b43a-259d-997c-41e6-5e84a91b012a@kernel.dk>
Date:   Fri, 29 Nov 2019 09:16:18 -0800
From:   Jens Axboe <axboe@...nel.dk>
To:     Christophe Leroy <christophe.leroy@....fr>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        Pavel Begunkov <asml.silence@...il.com>
Cc:     stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix
 dead-hung for non-iter fixed rw)

On 11/29/19 8:14 AM, Christophe Leroy wrote:
> 
> 
> Le 29/11/2019 à 17:04, Jens Axboe a écrit :
>> On 11/29/19 6:53 AM, Christophe Leroy wrote:
>>>      CC      fs/io_uring.o
>>> fs/io_uring.c: In function ‘loop_rw_iter’:
>>> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’
>>> [-Werror=implicit-function-declaration]
>>>        iovec.iov_base = kmap(iter->bvec->bv_page)
>>>                         ^
>>> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer
>>> without a cast [-Wint-conversion]
>>>        iovec.iov_base = kmap(iter->bvec->bv_page)
>>>                       ^
>>> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’
>>> [-Werror=implicit-function-declaration]
>>>        kunmap(iter->bvec->bv_page);
>>>        ^
>>>
>>>
>>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
>>> fixed rw") clears the failure.
>>>
>>> Most likely an #include is missing.
>>
>> Huh weird how the build bots didn't catch that. Does the below work?
> 
> Yes it works, thanks.

Thanks for reporting and testing, I've queued it up with your reported
and tested-by.

-- 
Jens Axboe