linux-kernel - Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0101016ec583b87a-6f10681d-2567-4ae8-bf1b-d78404ad26fb-000000@us-west-2.amazonses.com>
Date:   Mon, 2 Dec 2019 07:29:34 +0000
From:   cang@...eaurora.org
To:     Avri Altman <Avri.Altman@....com>
Cc:     asutoshd@...eaurora.org, nguyenb@...eaurora.org,
        rnayak@...eaurora.org, linux-scsi@...r.kernel.org,
        kernel-team@...roid.com, saravanak@...gle.com, salyzyn@...gle.com,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Bean Huo <beanhuo@...ron.com>,
        Evan Green <evgreen@...omium.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

On 2019-12-02 15:23, Avri Altman wrote:
> Hi,
>> 
>> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg 
>> an unique
>> ID by appending the scsi host number to its device name.
> Can you refer me to such a design?
> 
> Thanks,
> Avri
> 

Consider a platform which has an embedded UFS device and supports a UFS 
card meanwhile.
This conbination is very popular nowadays. BTW, 845 started supporting 
two UFS hosts 3 years ago.

Thanks,

Can Guo

>> 
>> Signed-off-by: Can Guo <cang@...eaurora.org>
>> 
>> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c 
>> index
>> dc2f6d2..3ef5b78 100644
>> --- a/drivers/scsi/ufs/ufs_bsg.c
>> +++ b/drivers/scsi/ufs/ufs_bsg.c
>> @@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
>>         bsg_dev->parent = get_device(parent);
>>         bsg_dev->release = ufs_bsg_node_release;
>> 
>> -       dev_set_name(bsg_dev, "ufs-bsg");
>> +       dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
>> 
>>         ret = device_add(bsg_dev);
>>         if (ret)
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project