linux-kernel - Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191202230642.GD32696@zn.tnic>
Date:   Tue, 3 Dec 2019 00:06:42 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Fenghua Yu <fenghua.yu@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, H Peter Anvin <hpa@...or.com>,
        Tony Luck <tony.luck@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Babu Moger <babu.moger@....com>,
        Andre Przywara <Andre.Przywara@....com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests

On Mon, Dec 02, 2019 at 10:53:35AM -0800, Fenghua Yu wrote:
> Babu's major contributions are in v5 where he virtually touched every
> patch. He sent out v5 and put Signed-off-by: Babu Moger in each patch:
> https://lore.kernel.org/patchwork/cover/1033532/
> 
> That's why I keep his SOB in v6-v8 in each patch.

For that you either need to use

Co-developed-by: Babu

or state the fact that Babu did contribute to the patches in freetext in
the commit messages.

As it is now, it is not clear what it means. You could've kept the order
from v5 since you took his submission and could've done:

Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
Signed-off-by: Babu Moger <babu.moger@....com>
Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>

to show you're the author, Babu handled them further and you're sending
the patchset now, but the other thing I suggested above is more clear
IMO.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette