linux-kernel - Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191203072824.GA1765@kadam>
Date:   Tue, 3 Dec 2019 10:28:24 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to
 variable i

On Mon, Dec 02, 2019 at 03:13:52PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable i is being initialized with a value that is never
> read and it is being updated later with a new value in a for-loop.
> The initialization is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/misc/ti-st/st_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
> index 2ae9948a91e1..6255d9b88122 100644
> --- a/drivers/misc/ti-st/st_core.c
> +++ b/drivers/misc/ti-st/st_core.c
> @@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty)
>  
>  static void st_tty_close(struct tty_struct *tty)
>  {
> -	unsigned char i = ST_MAX_CHANNELS;
> +	unsigned char i;
>  	unsigned long flags = 0;

I'm surprised that flags doesn't generate a warning as well.

regards,
dan carpenter